Submitting patches to DbUnit...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Submitting patches to DbUnit...

Darryl L. Pierce-2
I submitted a patch[1] the other day to DbUnit. How often/quickly does
the team review patches and consider them for inclusion in the project?


[1] -
https://sourceforge.net/tracker/?func=detail&atid=449494&aid=3170998&group_id=47439
--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/


------------------------------------------------------------------------------
The modern datacenter depends on network connectivity to access resources
and provide services. The best practices for maximizing a physical server's
connectivity to a physical network are well understood - see how these
rules translate into the virtual world?
http://p.sf.net/sfu/oracle-sfdevnlfb
_______________________________________________
dbunit-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/dbunit-user

attachment0 (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Submitting patches to DbUnit...

Jeff Jensen-2
Sometimes quickly, sometimes a disappointing slowness.  :-(

Thank you for the patch - and the ping.

Are there any backwards compat concerns with the change (and you are
correct in that first thought - I have not looked at the patch changes
yet :-).


On Fri, Feb 4, 2011 at 6:51 AM, Darryl L. Pierce <[hidden email]> wrote:

> I submitted a patch[1] the other day to DbUnit. How often/quickly does
> the team review patches and consider them for inclusion in the project?
>
>
> [1] -
> https://sourceforge.net/tracker/?func=detail&atid=449494&aid=3170998&group_id=47439
> --
> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/

------------------------------------------------------------------------------
The modern datacenter depends on network connectivity to access resources
and provide services. The best practices for maximizing a physical server's
connectivity to a physical network are well understood - see how these
rules translate into the virtual world?
http://p.sf.net/sfu/oracle-sfdevnlfb
_______________________________________________
dbunit-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/dbunit-user
Reply | Threaded
Open this post in threaded view
|

Re: Submitting patches to DbUnit...

Darryl L. Pierce-2
On Fri, Feb 04, 2011 at 08:22:50AM -0600, Jeff Jensen wrote:
> Sometimes quickly, sometimes a disappointing slowness.  :-(
>
> Thank you for the patch - and the ping.
>
> Are there any backwards compat concerns with the change (and you are
> correct in that first thought - I have not looked at the patch changes
> yet :-).

I haven't tested it with anything older then SQLServer Express 2005. But
I don't think it will be an issue with any version that doesn't have a
uniqueidentifier column.

--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/


------------------------------------------------------------------------------
The modern datacenter depends on network connectivity to access resources
and provide services. The best practices for maximizing a physical server's
connectivity to a physical network are well understood - see how these
rules translate into the virtual world?
http://p.sf.net/sfu/oracle-sfdevnlfb
_______________________________________________
dbunit-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/dbunit-user

attachment0 (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Submitting patches to DbUnit...

Darryl L. Pierce-2
In reply to this post by Jeff Jensen-2
On Fri, Feb 04, 2011 at 08:22:50AM -0600, Jeff Jensen wrote:
> Sometimes quickly, sometimes a disappointing slowness.  :-(
>
> Thank you for the patch - and the ping.
>
> Are there any backwards compat concerns with the change (and you are
> correct in that first thought - I have not looked at the patch changes
> yet :-).

Hey, Jeff, wanted to follow up again. I updated the patch on the ticket,
any chance of testing it out to see if it can get into the codebase?

--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/


------------------------------------------------------------------------------
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
_______________________________________________
dbunit-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/dbunit-user

attachment0 (205 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Submitting patches to DbUnit...

Jeff Jensen-2
Sorry Darryl, just been really pinched for time.  I intended to do it
last weekend but worked on my current customer's stuff most of Sat and
Sun :-/
It is on my radar though, and my first review looked good sans the
issues you corrected for patch 2.

I hope for this weekend!  Thanks for the ping.


On Thu, Apr 7, 2011 at 7:30 AM, Darryl L. Pierce <[hidden email]> wrote:

> On Fri, Feb 04, 2011 at 08:22:50AM -0600, Jeff Jensen wrote:
>> Sometimes quickly, sometimes a disappointing slowness.  :-(
>>
>> Thank you for the patch - and the ping.
>>
>> Are there any backwards compat concerns with the change (and you are
>> correct in that first thought - I have not looked at the patch changes
>> yet :-).
>
> Hey, Jeff, wanted to follow up again. I updated the patch on the ticket,
> any chance of testing it out to see if it can get into the codebase?
>
> --
> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
>
>
> ------------------------------------------------------------------------------
> Xperia(TM) PLAY
> It's a major breakthrough. An authentic gaming
> smartphone on the nation's most reliable network.
> And it wants your games.
> http://p.sf.net/sfu/verizon-sfdev
> _______________________________________________
> dbunit-user mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/dbunit-user
>
>

------------------------------------------------------------------------------
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
_______________________________________________
dbunit-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/dbunit-user